Especially for SSD's I think. "Tin foil hat" folks will remain concerned about "designed access" hardware schemes.
I'm very cautious when such hardware encryption technology is being sold openly to the public. If they're more unbreakable compared to software-based, then law enforcement will have more hard time trying to decrypt/crack a suspect's hard drive for petty wrongdoing like freedom of speech. It just doesn't make sense. Based on experience, software-based like FDE (full disk encryption) is still the reliable way. It only depends on the way someone customizes its encryption like cascading method, decoy and destruction mechanism. Cold boot attack, though much buzz, is not workable in most cases.
I think I'd be very cautious whoever I was! Before you know it, it'll have a Clipper chip hidden in it. What I would like to see is more open-source projects based on something like the Arduino or Raspberry Pi. Hard to get the business model, though I guess some of the privacy-oriented crowd-funded attempts go that way. As it is, much of the hype seems to be about encrypted SSD and storage - OK as far as it goes, but doing nothing whatsoever to protect against remote or insider threats - which, if experience is any guide - is the most significant threat. So, I agree - you have to have control over the functionality, which means software.
